Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gtk-murrine-engine - Murrine GTK2 engine https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215224 ------- Additional Comments From karlthered@xxxxxxxxx 2006-11-16 15:48 EST ------- Even if you're not a sponsor or neither an Extras maintainers shouldn't stop you from reviewing packages. It might help accelerating the reviewing process. :o) Leon have you been sponsored ? By the way, you should use your real name and not an alias in the spec. OK - Package name OK - Spec file matches base package name. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. See below - Sources match upstream md5sum (1) OK - Package compiles and builds on at least one arch. OK - BuildRequires correct OK - Spec has needed ldconfig in post and postun OK - Package owns all the directories it creates. OK - Package has no duplicate files in %files. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Spec has consistant macro usage. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Headers/static libs in -devel subpackage. OK - .pc files in -devel subpackage. OK - .so files in -devel subpackage. OK - -devel package Requires: %{name} = %{version}-%{release} OK - .la files are removed. OK - Package doesn't own any directories other packages own. See below - No rpmlint output. (2) SHOULD Items: OK - Should include License or ask upstream to include it. OK - Should build in mock. 1. I haven't found download link for these themes MurrinaBlack and MurrinaTango on murrine website. Could you provide them in order to check md5sum ? Is there any reason not to package other themes ? 2. you should think about splitting the package, something like that - gtk-murrine-engine: the gtk engine (plus maybe the configurator script available on the website ?) - gnome-themes-murrine-bigpack: gnome murrine themes pack It will ease your future work as maintainer. 3. It lacks rpmlint output: $ rpmlint -i gtk-murrine-engine-0.31-1.leofc5.i386.rpm W: gtk-murrine-engine summary-ended-with-dot Murrine GTK2 engine. Summary ends with a dot. W: gtk-murrine-engine incoherent-version-in-changelog 0.30.2 0.31-1 The last entry in %changelog contains a version identifier that is not coherent with the epoch:version-release tuple of the package. E: gtk-murrine-engine script-without-shebang /usr/share/themes/Murrina-Black/gtk-2.0/gtkrc This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere. These are easily fixable. Has anyone tested the package on another supported hardware platforms such as x86_64 ? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review