Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=628280 --- Comment #4 from Alexander Kurtakov <akurtako@xxxxxxxxxx> 2010-08-31 01:41:57 EDT --- Review: OK: rpmlint must be run on every package. Output: apache-commons-collections-testframework.noarch: W: no-documentation apache-commons-collections.noarch: W: non-conffile-in-etc /etc/maven/fragments/apache-commons-collections Not a problem OK: The package must be named according to the Package Naming Guidelines . OK: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK: The package must meet the Packaging Guidelines . OK: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . OK: The License field in the package spec file must match the actual license. OK: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK: The spec file must be written in American English. OK: The spec file for the package MUST be legible. OK: The sources used to build the package must match the upstream source, as provided in the spec URL. OK: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. OK: Packages must NOT bundle copies of system libraries. OK: A package must own all directories that it creates. OK: A Fedora package must not list a file more than once in the spec file's %files listings. OK: Permissions on files must be set properly. Executables should be set with executable permissions, for example. OK: Each package must consistently use macros. OK: The package must contain code, or permissable content. OK: Large documentation files must go in a -doc subpackage. OK: If a package includes something as %doc, it must not affect the runtime of the application. FIXIT: Packages must not own files or directories already owned by other packages. You are using %{_datadir}/maven2/poms %{_mavendepmapfragdir} which are owned by jpackage-utils, you should use them like %{_datadir}/maven2/poms/* %{_mavendepmapfragdir}/* to list only the files not the directories Or even better: OK: All filenames in rpm packages must be valid UTF-8. [24] Not a problem but it would be nice if you use the new maven plugins names, e.g. maven2-plugin-antrun is now called maven-antrun-plugin Other than the small directory owning problem everything else is good. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review