Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589866 --- Comment #27 from Dmitrij S. Kryzhevich <krege@xxxxxxx> 2010-08-30 21:34:19 EDT --- (In reply to comment #26) > Build is fine under mock, rpmlint output: > darktable.i686: W: non-conffile-in-etc /etc/gconf/schemas/darktable.schemas > A non-executable file in your package is being installed in /etc, but is not a > configuration file. All non-executable files in /etc should be configuration > files. Mark the file as %config in the spec file. Hm. > PS: Sorry Dimitrij can't get your files from depositfiles. May be you can suggest another file storage? I haven't my own. Diff between yours: 1. %configure --disable-schemas \ --disable-static ------------------------------------------- First - might be clear, second - not to make static libs. 2. %post update-desktop-database &> /dev/null ||: touch --no-create %{_datadir}/icons/hicolor &>/dev/null || : ------------------------------------------- First - register .desktop file, second - update icons db. 3. %postun update-desktop-database &> /dev/null || : if [ $1 -eq 0 ] ; then touch --no-create %{_datadir}/icons/hicolor &>/dev/null gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : fi %posttrans gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : ------------------------------------------- The same. 4. In .desktop patch I'm removing only one space char but not empty strings, they are allowed. 5. I haven't Requires(pre/post/preun). In Fedora they are not required, only in RHEL. Do you want to maintain darktable in RHEL? 6. %gconf_schema_* can work with argument without .schemas (i.e. %gconf_schema_prepare darktable). I don't know, is it even correct to add .schemas. But - I don't know, so if it works - it works. In examples .schemas omitted. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review