[Bug 627877] Review Request: jibx - JiBX is a framework for binding XML data to Java objects.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=627877

--- Comment #3 from Stanislav Ochotnicky <sochotni@xxxxxxxxxx> 2010-08-30 11:48:43 EDT ---
Few notes first:
 * you should run rpmlint on your spec files/SRPM/RPMs
 * Fedora guidelines are strict about bundling dependencies. And jibx archive
has quite a few of them. Run:
   $ find -name '*.class' -exec rm -f '{}' \;
   $ find -name '*.jar' -exec rm -f '{}' \;
   this will cause your current build to fail because of missing BRs. I
verified it can be built with Fedora packages, if you need help figuring out
what BRs to add let me know
 * after doing previous you will have to do something like this for eclipse
dependencies:
plugin_file=`ls
%{_libdir}/eclipse/dropins/jdt/plugins/org.eclipse.jdt.core_*jar`
ln -s "$plugin_file" lib/org.eclipse.jdt.core.jar

 * package should be BuildArch:noarch
 * Are you sure about package Requires? Is and really necessary for package to
work? I am guessing not. Similarly other libraries are probably not needed
beside java. It's better to start with fewer Requires, even missing some
because we'll find out. But it's hard to discover unneeded dependencies that
will just make user's system bloated over time
 * You use sed in one place and perl in other to do the same thing, it's best
to just use sed if it can do the job
 * build/docs/src should be removed prior to installing documentation, those
are just files used to build it AFAIK


If you need help sorting out those problems find me on IRC and we can do it
step-by-step

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]