[Bug 588433] Review Request: rubygem-echo - ruby gem pacaking tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=588433

Michael Stahnke <mastahnke@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |mastahnke@xxxxxxxxx

--- Comment #1 from Michael Stahnke <mastahnke@xxxxxxxxx> 2010-08-29 22:40:14 EDT ---
%ruby_sitelib is not used or needed in this spec.  Please remove it. 


 rpmlint rubygem-echoe-4.3-1.fc15.src.rpm 
rubygem-echoe.src: E: summary-too-long C A Rubygems packaging tool that
provides Rake tasks for documentation, extension compiling, testing, and
deployment
rubygem-echoe.src:42: W: mixed-use-of-spaces-and-tabs (spaces: line 37, tab:
line 42)
1 packages and 0 specfiles checked; 1 errors, 1 warnings.

 rpmlint rubygem-echoe-4.3-1.fc15.noarch.rpm 
rubygem-echoe.noarch: E: non-executable-script
/usr/lib/ruby/gems/1.8/gems/echoe-4.3/vendor/rake/lib/rake/contrib/compositepublisher.rb
0644L /usr/bin/env
rubygem-echoe.noarch: E: non-executable-script
/usr/lib/ruby/gems/1.8/gems/echoe-4.3/vendor/rake/lib/rake/contrib/ftptools.rb
0644L /usr/bin/env
rubygem-echoe.noarch: E: non-executable-script
/usr/lib/ruby/gems/1.8/gems/echoe-4.3/vendor/rake/lib/rake/contrib/rubyforgepublisher.rb
0644L /usr/bin/env
rubygem-echoe.noarch: E: non-executable-script
/usr/lib/ruby/gems/1.8/gems/echoe-4.3/vendor/rake/lib/rake/contrib/sys.rb 0644L
/usr/bin/env
rubygem-echoe.noarch: E: non-executable-script
/usr/lib/ruby/gems/1.8/gems/echoe-4.3/vendor/rake/lib/rake/contrib/publisher.rb
0644L /usr/bin/env


This section is not needed, and it even breaks trying to run the Rakefile in a
%check (however this rakefile has no test/spec option)  Please remove it. 
Files can marked as %doc outside of /usr/share/doc.
mkdir -p %{buildroot}/usr/share/doc/%{gemdir}-%{version}
for DOC in LICENSE CHANGELOG README TODO
    do mv  %{buildroot}%{geminstdir}/$DOC
%{buildroot}/usr/share/doc/%{gemdir}-%{version}
done

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]