Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=607584 --- Comment #13 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-08-29 14:15:03 EDT --- For 0.3b-4: * Source tarball -------------------------------------------------------------- 26340 wordgroupz-0.3b-1.fc13.src/wordgroupz-0.3b.tar.gz 50345 wordgroupz-0.3b-4.fc13.src/wordgroupz-0.3b.tar.gz -------------------------------------------------------------- - What happened here? Tarball itself must not be released until the version number is changed. If you are the upstream and you modified the source codes themselves, please change the version number of the tarball to avoid confusion. * Macros in comments - As I said in my previous comment, rpmlint still complaints: -------------------------------------------------------------- wordgroupz.src:13: W: macro-in-comment %{_tmppath} wordgroupz.src:13: W: macro-in-comment %{name} wordgroupz.src:13: W: macro-in-comment %{version} wordgroupz.src:13: W: macro-in-comment %{release} wordgroupz.src:21: W: macro-in-comment %{name} -------------------------------------------------------------- The lines 13 and 21 are no longer needed. Please remove these unneeded comments. - If you want to keep these comments, please use %% instead of % in comments so that macros won't be expanded. * Requires - For "Requires: python-sqlite2" wordgroupz.py says: -------------------------------------------------------------- 19 import sqlite3 -------------------------------------------------------------- This uses sqlite3, not sqlite2, so "Requires: python-sqlite2" is not needed. Also "sqlite3" module is already in python rpm. - For "Requires: python-matplotlib" Why is this needed? It seems that the lines related to matplotlib are all commented out. * desktop file, - As I said before, "Application" in "Categories" item in %_datadir/applications/%name.desktop is redundant and should be removed. * Unneeded shebangs --------------------------------------------------------------- wordgroupz.noarch: E: non-executable-script /usr/share/wordgroupz/espeak.py 0644L /bin/env wordgroupz.noarch: E: non-executable-script /usr/share/wordgroupz/games.py 0644L /usr/bin/evn wordgroupz.noarch: E: non-executable-script /usr/share/wordgroupz/get_fields.py 0644L /usr/bin/env wordgroupz.noarch: E: non-executable-script /usr/share/wordgroupz/html2text.py 0644L /usr/bin/env wordgroupz.noarch: W: no-manual-page-for-binary wordgroupz --------------------------------------------------------------- - Shebangs on these files are unneeded because these scripts don't have exectuable permission. Also some files have wrong shebangs, anyway these shebangs should be removed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review