Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598315 Miloš Komarčević <miloskomarcevic@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |miloskomarcevic@xxxxxxxxxxx | |t --- Comment #2 from Miloš Komarčević <miloskomarcevic@xxxxxxxxxxxx> 2010-08-29 08:58:52 EDT --- Hi Andrew, I'm not an official Fedora reviewer, but I'd like to offer some feedback to help you move things along sice I think this would be a vrey useful package for e.g. FEL: - The spec file in your URL above contains some HTML tags so it is corrupt when downloaded, please fix - Looking at the actual code, license should be GPLv2+ - Please use sentence case in the description, and feel free to be more verbose, e.g. a full paragraph from the web page... - Add libusb-devel, libftdi-devel and readline-devel in BuildRequires to enable all the features of the program, it's a bit useless without them... - No need for BuildRoot tag for F10 and later; no need for %clean section for F13 and later; maybe prefer using the %{buildroot} macro instead of $RPM_BUILD_ROOT variable in the %install section, see http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag - %doc section is missing NEWS and perhaps ChangeLog - %changelog section should list _your_ changes to the spec file, not the program's changes, see http://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review