Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=628280 --- Comment #2 from Alexander Kurtakov <akurtako@xxxxxxxxxx> 2010-08-29 08:06:59 EDT --- First impressions: * You don't need Source1 ... Source5 and %patch1. These are not needed nowadays anymore we have a proper maven environment. * You can also remove the following from the %build section: export DEPCAT=$(pwd)/commons-collections-3.2-depcat.new.xml echo '<?xml version="1.0" standalone="yes"?>' > $DEPCAT echo '<depset>' >> $DEPCAT for p in $(find . -name project.xml); do pushd $(dirname $p) /usr/bin/saxon project.xml %{SOURCE1} >> $DEPCAT popd done echo >> $DEPCAT echo '</depset>' >> $DEPCAT /usr/bin/saxon $DEPCAT %{SOURCE2} > commons-collections-3.2-depmap.new.xml for p in $(find . -name project.xml); do pushd $(dirname $p) cp project.xml project.xml.orig /usr/bin/saxon -o project.xml project.xml.orig %{SOURCE3} map=%{SOURCE4} popd done It was needed for maven1 build which is something we don't do in Fedora * rpmlint gives: - apache-commons-collections-testframework-javadoc.noarch: W: non-standard-group Development/Documentation Should be Documentation - apache-commons-collections-testframework.noarch: W: non-standard-group Development/Testing Maybe Development/Tools - apache-commons-collections-testframework.noarch: W: no-documentation Not a real problem. - apache-commons-collections-testframework.noarch: W: empty-%post - apache-commons-collections-testframework.noarch: W: empty-%postun When you don't have what to put in these sections just remove them. - apache-commons-collections.noarch: W: non-standard-group Development/Libraries/Java Should be Development/Libraries - apache-commons-collections.noarch: W: non-conffile-in-etc /etc/maven/fragments/apache-commons-collections Not a problem - apache-commons-collections-javadoc.noarch: W: non-standard-group Development/Documentation Should be Documentation - apache-commons-collections-tomcat5.noarch: W: non-standard-group Development/Libraries/Java should be Development/Libraries - apache-commons-collections-tomcat5.noarch: W: empty-%post - apache-commons-collections-tomcat5.noarch: W: empty-%postun Remove empty sections like this. * file permissions is %defattr(0644,root,root,0755) but the preferred way is %defattr(-,root,root,-) so when/if defaults changes they will be picked up just by a rebuild Once these issues are fixed I'll do the official review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review