Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=627024 Terje Røsten <terjeros@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |terjeros@xxxxxxxxxxxx --- Comment #3 from Terje Røsten <terjeros@xxxxxxxxxxxx> 2010-08-29 03:23:27 EDT --- > You are using mix of %{__perl} macros and many of plain commands like make, rm, > find. Please choose one form. I think easy replace macros by plain call to > perl. This have been discussed before, it's okay to mix %{__foo} and shell commands. In fact is very usefull e.g. when shipping python and python3 packages, and perl and perl6 packages in the future. However, it's not good style to mix e.g. cp and %{__cp} or rm and %{__mkdir}. Then the last rule: if in doubt let the packager decide. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review