Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: beryl-dbus - Beryl OpenGL window and compositing manager dbus plug-in https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215568 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2006-11-16 11:54 EST ------- Well, 1. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines : * BuildRequires: - Well, too much redundant BuildRequires (I don't like this...) All needed are: ------------------------------------------------- beryl-core-devel >= %{version} dbus-devel ++++++++ libXcomposite-devel libXdamage-devel libSM-devel libpng-devel libXext-devel libXinerama-devel startup-notification-devel libXrandr-devel libXrender-devel ++++++++ ------------------------------------------------- Actually these dependency finally 98 minimal build enviroment + 42 other package (tol: 140), while your original package tries to install 276 package. NOTE: The packages between +(plus) symbols, i.e. ------------------------------------------------- libXcomposite-devel libXdamage-devel libSM-devel libpng-devel libXext-devel libXinerama-devel startup-notification-devel libXrandr-devel libXrender-devel ------------------------------------------------- should be required by beryl-core-devel (check /usr/lib/pkgconfig/beryl.pc) so beryl-core-devel package should be fixed. After that this package should only require: -------------------------------------------------- beryl-core-devel >= %{version} dbus-devel -------------------------------------------------- for BuildRequires (I want to check this again so that would you fix beryl-core-devel first?) * Requires: - dbus This is not necessary as libraries' dependency automatically pulls this. 2. Other things I have noticed : * %doc - Well /usr/share/doc/beryl-dbus-0.1.2/ChangeLog says: ------------------------------------------------- see debian/changelog ------------------------------------------------- ... however, where is debian/changelog? 99. For other packages: 99-A For beryl-core package: * Well, rpmlint is not silent. -------------------------------------------------- W: beryl-core undefined-non-weak-symbol /usr/lib/libberylsettings.so.0.0.0 g_free W: beryl-core undefined-non-weak-symbol /usr/lib/libberylsettings.so.0.0.0 g_free W: beryl-core undefined-non-weak-symbol /usr/lib/libberylsettings.so.0.0.0 g_slist_remove W: beryl-core undefined-non-weak-symbol /usr/lib/libberylsettings.so.0.0.0 g_mkdir_with_parents W: beryl-core undefined-non-weak-symbol /usr/lib/libberylsettings.so.0.0.0 g_key_file_has_key ....(too much) --------------------------------------------------- Perhaps linking against glib or something else is not correct. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review