Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=618480 --- Comment #3 from Chen Lei <supercyper1@xxxxxxxxx> 2010-08-27 07:50:45 EDT --- (In reply to comment #2) > [-] MUST: The package must be named according to the Package Naming Guidelines. > As it only library it should start from "lib" prefix. We should not add lib to the pkgname, see http://fedoraproject.org/wiki/PackageNamingGuidelines#General_Naming > [-] MUST: The package must meet the Packaging Guidelines. This is an installation patch and irrelevant to upstream. > [-] MUST: The License field in the package spec file must match the actual > license. > License tag should be GPLv3+ according to comments in sources. Several months ago, I confirm this issue when submitting QTeXEngine to fedora. See http://soft.proindependent.com/emf/licensing.html > [-] MUST: At the beginning of %install, each package MUST run rm -rf > %{buildroot} (or $RPM_BUILD_ROOT). > About it also complain rpmlint, please fix. Buildroot is no longer needer for fedora. See http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag > [+/-] MUST: In the vast majority of cases, devel packages must require the base > package using a fully versioned dependency: Requires: %{name} = > %{version}-%{release} > See note 2 below. > Some note: > 1) Just for polish. May be have worth dos2unix all files in one command: > find -name '*.h' -or -name '*.hh' -or -name '*.hpp' -or -name '*.c' -or -name > '*.cc' -or -name '*.cpp' -exec dos2unix -k {} \; > Furtermore, as we pack in -devel only headers, converting of sources (*.c, > *.cc, *.cpp) seems unnecessary. *.cpp file will be included in -debuginfo subpackage, so we should convert all source files to unix line ending. > 2) I'm do not understand for what you add %{?_isa} in requires and > buildrequires of -devel sub-package? Are headers different or arch dependent? See http://fedoraproject.org/wiki/PackagingDrafts/ArchSpecificRequires -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review