Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=619237 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #4 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-08-27 06:06:51 EDT --- Hi Silas, here are some more things to consider: - add a comment telling what the patch does - append CFLAGS='%{optflags} -std=c99' to the "make" statement in order to apply Fedora's default build flags (I also suggest to replace %{__make} with "make") - add "sed -i '/^DEBUG/d' Makefile" before "make" (or patch the Makefile) to remove the additional debug flags - add the following files with %doc: 00-RELEASENOTES, BUGS, Changelog, TODO and drop README as it doesn't contain any useful information - if you plan to maintain this package for Fedora only, replace %{_initrddir} with %{_initddir} (%{_initrddir} is deprecated but still required for EPEL <= 5) - in the scriptlets, ensure that stderr is also redirected to /dev/null, e.g. by adding "2>&1" - I recommend to add a check for the config file to function start() in the initscript: [ -f $REDIS_CONFIG ] || exit 6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review