Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=625855 --- Comment #2 from Emmanuel Seyman <emmanuel.seyman@xxxxxxxxxxxxxxxx> 2010-08-26 19:15:08 EDT --- (In reply to comment #1) > > 1. I think there is no reason to include ignore.txt , it adds nothing > to the package. You're right, done. > 2. Can you contact upstream to request a LICENSE file. Done. http://rt.cpan.org/Ticket/Display.html?id=60759 > 3. I have been asked previously to change: > > make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT > to > make pure_install DESTDIR=$RPM_BUILD_ROOT > > and is something I always do. Done. > 4. The fail in mock of course. Fixed by adding perl(version) in the BuildRequires Spec URL: http://people.parinux.org/~seyman/fedora/perl-EBook-EPUB/perl-EBook-EPUB.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-EBook-EPUB/perl-EBook-EPUB-0.5-2.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review