Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=619228 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #1 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-08-26 15:20:04 EDT --- Hi Jochen, is this your first package submission for Fedora? I can't find you in the packager group. If so, please add FE-NEEDSPONSOR to the Blocks field above and see [1] for further details. [1] https://fedoraproject.org/wiki/PackageMaintainers/Join#How_to_join_the_Fedora_Package_Collection_Maintainers.3F Here are some initial comments on your package: - drop the final dot from Summary - append %{?dist} to the Release number - Source0 should contain a complete URL pointing to the upstream tarball - The %description lines should not exceed 80 characters. Split them properly. - Replace "./configure --prefix=/usr --bindir=/usr/sbin" with "%configure --bindir=%{_sbindir}" The %configure macro sets a couple of variables to Fedora defaults. - In %build, append %{_smp_mflags} to "make" in order to enable parallel builds. - replace DESTDIR=$RPM_BUILD_ROOT make install with make install DESTDIR=$RPM_BUILD_ROOT - use macros in the %install and %files section: /usr/sbin -> %{_sbindir} /usr/share/man -> %{_mandir} /etc/init.d -> %{_initddir} /etc -> %{_sysconfdir} - drop INSTALL from %files (it's not of much use in a binary package) - drop "%config" from "%config /etc/init.d/shellinabox" as this file is a script and not a configuration file - replace "1.gz" with "1*" since the compression format applied by rpmbuild could change - I suggest to add the demo folder as %doc - If you want to maintain the package for Fedora only, the Buildroot tag and "rm -rf $RPM_BUILD_ROOT" in %install is not required any longer. However, you still need them for EPEL 4 and 5. - Add version and release number to the %changelog header. See https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs - The init script must be adapted according to the Fedora guidelines. See http://fedoraproject.org/wiki/Packaging/SysVInitScript - Also see here how to install the init scripts properly: http://fedoraproject.org/wiki/Packaging/SysVInitScript#InitscriptScriptlets That's all for now. :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review