Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598511 --- Comment #5 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2010-08-24 12:24:01 EDT --- rpmlint output: libgtextutils.src: W: spelling-error Summary(en_US) Assaf -> Assad, Assam, Assai libgtextutils.src: W: spelling-error %description -l en_US fastx -> fast, fasts, fast x libgtextutils.x86_64: W: spelling-error Summary(en_US) Assaf -> Assad, Assam, Assai libgtextutils.x86_64: W: spelling-error %description -l en_US fastx -> fast, fasts, fast x libgtextutils-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 5 warnings. These are OK. ** I recommend using just http://hannonlab.cshl.edu/fastx_toolkit/ as the URL. ** MUST: The package does not yet exist in Fedora. The Review Request is not a duplicate. OK MUST: The spec file for the package is legible and macros are used consistently. NEEDSWORK - You are mixing %{optflags} and $RPM_BUILD_ROOT. This is not allowed. http://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS - The %files section could use some clarity. Using wildcards where they are not needed is bad style, and packages might end up owning stuff they're not supposed to. Please change %{_includedir}/* to %{_includedir}/gtextutils/ and consider also using %{_libdir}/libgtextutils-*.so.* %{_libdir}/libgtextutils-*.so MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. NEEDSWORK - licensecheck reports: ./src/gtextutils/string_tokenize.h: AGPL (v3 or later) and the same for other files as well. Looking at the license text itself confirms that this is a "v3 or later" license. => License tag should be AGPLv3+. MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK d6969aa0d31cc934e1fedf3fe3d0dc63 libgtextutils-0.6.tar.bz2 d6969aa0d31cc934e1fedf3fe3d0dc63 ../SOURCES/libgtextutils-0.6.tar.bz2 MUST: The package MUST successfully compile and build into binary rpms. OK MUST: The spec file MUST handle locales properly. N/A MUST: Optflags are used and time stamps preserved. NEEDSWORK - The compilation process adds some of its own flags: " -Wextra -Wformat-nonliteral -Wformat-security -Wswitch-default -Wswitch-enum -Wunused-parameter -Wfloat-equal -Werror -DDEBUG -g -O1 -DDEBUG -g -O1 -version-info 0:0:0 -release 0.6" - You must get rid of at least the "-g -O1". You'll need to patch configure to do this. I suggest removing lines 15093-15100 altogether, which read if test "$debug" = "true" then CFLAGS="${CFLAGS} -DDEBUG -g -O1" CXXFLAGS="${CFLAGS} -DDEBUG -g -O1" else CFLAGS="${CFLAGS} -O3" CXXFLAGS="${CFLAGS} -O3" fi MUST: Packages containing shared library files must call ldconfig. OK MUST: A package must own all directories that it creates or require the package that owns the directory. OK MUST: Files only listed once in %files listings. OK MUST: Debuginfo package is complete. OK MUST: Permissions on files must be set properly. OK MUST: Large documentation files must go in a -doc subpackage. OK MUST: All relevant items are included in %doc. Items in %doc do not affect runtime of application. OK MUST: Header files must be in a -devel package. OK MUST: Static libraries must be in a -static package. N/A MUST: If a package contains library files with a suffix then library files ending in .so must go in a -devel package. OK MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency. OK MUST: Packages does not contain any .la libtool archives. OK MUST: Desktop files are installed properly. N/A MUST: No file conflicts with other packages and no general names. OK SHOULD: %{?dist} tag is used in release. OK SHOULD: If the package does not include license text(s) as separate files from upstream, the packager should query upstream to include it. OK SHOULD: The package builds in mock. OK EPEL: Clean section exists. OK EPEL: Buildroot cleaned before install. OK EPEL: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. OK -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review