Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626446 --- Comment #3 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2010-08-24 03:28:39 EDT --- (In reply to comment #2) > Hi Peter, here are some quick comments: Hello Martin! > - File %{_datadir}/aclocal/winfuncs.m4 is licensed under GPLv2+. This should > be reflected in the License tag of the devel package (LGPLv2+ and GPLv2+). > > - I recommend to replace %{_includedir}/* with %{_includedir}/%{name}/ > > - The folder %{_datadir}/%{name}/examples/ contains sample source code and > should probably be added with %doc. Thanks for the quick reply - I'll fix these issues shortly. Stay tuned! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review