Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: emerald - Themeable window decorator and compositing manager for Beryl https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209263 mr.ecik@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mr.ecik@xxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From mr.ecik@xxxxxxxxx 2006-11-15 14:24 EST ------- MUST items: !* rpmlint output: E: emerald binary-or-shlib-defines-rpath /usr/lib64/emerald/engines/ libpixmap.so ['/usr/lib64'] E: emerald binary-or-shlib-defines-rpath /usr/lib64/emerald/engines/ libtruglass.so ['/usr/lib64'] E: emerald binary-or-shlib-defines-rpath /usr/lib64/emerald/engines/ libvrunner.so ['/usr/lib64'] E: emerald binary-or-shlib-defines-rpath /usr/lib64/emerald/engines/ liboxygen.so ['/usr/lib64'] E: emerald binary-or-shlib-defines-rpath /usr/lib64/emerald/engines/ liblegacy.so ['/usr/lib64'] E: emerald binary-or-shlib-defines-rpath /usr/lib64/emerald/engines/ libzootreeves.so ['/usr/lib64'] E: emerald binary-or-shlib-defines-rpath /usr/bin/emerald-theme-manager ['/usr/ lib64'] E: emerald binary-or-shlib-defines-rpath /usr/bin/emerald ['/usr/lib64'] W: emerald-devel no-documentation * package is named well * spec file name is good * package meets Packaging Guidelines * package is licensed with a GPL open-source compatible license * License field in spec file matches actual license * license file is included in %doc * md5sums are matching (c273fe82c7e3b2867f05073f3b012708) * package successfully compiles on x86_64 * BuildRequires listed well (mock builds well) * spec file handles locales properly * proper %post and %postun sections * not relocatable * package owns directories well * no duplicates in %files * every %files section includes %defattr * proper %clean section * macros used well * -devel subpackage created good * .desktop file present and looks good THINGS to do: * you have to fix rpath issue by adding following lines to %prep section: sed -i 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g' libtool sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review