Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-DB-DataObject - An SQL Builder, Object Interface to Database Tables Alias: DB-DataObject https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212917 ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-11-15 13:45 EST ------- Something's odd with the changelog entry; it shows version 1.0.0-0.1.RC5 but the package version is 1.8.4. This causes an rpmlint complaint: W: php-pear-DB-DataObject incoherent-version-in-changelog 1.0.0-0.1.RC5 1.8.4-1.fc7 There's also this: E: php-pear-DB-DataObject non-executable-script /usr/share/pear/DB/DataObject/createTables.php 0644 I think this is actually an end-user executable. Should it really be buried under /usr/share, or should it be in /usr/bin? * source files match upstream: 770c44d243066340d639b063235dcc02 DB_DataObject-1.8.4.tgz * package meets naming and packaging guidelines. X The spec is fine except for the changelog. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (development, x86_64). * package installs properly X rpmlint has valid complaints. * final provides and requires are sane: php-pear(DB_DataObject) = 1.8.4 php-pear-DB-DataObject = 1.8.4-1.fc7 = /bin/sh /usr/bin/pear php-pear(DB) php-pear(Date) php-pear(MDB2) php-pear(PEAR) php-pear(Validate) * %check is not present; no test suite upstream. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. ? not sure about file permissions. * scriptlets are OK (pear module installation). * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review