Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=580447 --- Comment #14 from Petr Sabata <psabata@xxxxxxxxxx> 2010-08-23 11:33:23 EDT --- Basically, Chris has said it all. My comments: 1. Remove the unnecessary tab character on line 67. 2. I suppose we could go with 'sub-classing' to make rpmlint happier. 3. I don't think the MB_TEST_EXPERIMENTAL is really needed. But again, it's up to you. All in all, it looks okay. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review