Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: freepops - a tool to get html mail through a pop daemon https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208113 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2006-11-15 11:31 EST ------- Well, I only checked this package (freepops) by packaging issue and not fully checked yet, however it seems not a few issues to be fixed. Please fix the following before I can check this fully. Please make yourself familiar with the following URLs. http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ReviewGuidelines Then; 0. For spec file: 0-1 On Description stage: * Version: - Use %{?dist} tag. i.e. use 1%{?dist} - Note: every time use fix spec files, please increment release number. * Source2: - Executable flags on source is forbidden. - Please specify the URL (same for other sources). * BuildRoot: - The recommended BuildRoot are described on http://fedoraproject.org/wiki/Packaging/Guidelines * BuildRequires: - openssl-devel This is redundant because curl-devel requires this. * Requires: - All the requires written are not necessary because libraries' dependency automatically pulls them. * Patch: - Please rename the name of the patch to something like: 'freepops-0.0.99-configure.patch' so that it can again renamed when the content of the patch has to be updated when the original source changes. 0-2 On %prep stage: * %{update} %SOURCE3 - Well, doing some work (like expanding some files) except under $RPM_BUILD_DIR or $RPM_BUILD_ROOT is not allowed. * ./configure.sh - This should be in %build section 0-3 On %build section - make all Fedora specific compilation flags (can be checked by 'rpm --eval %optflags') are not used. * NOTE: Please use the option 'H=""' so that what 'make' process is actually doing. - WHERE=/usr/ Please use macros (i.e. WHERE=%{_prefix}) - FORCE_LINK="-L /tmp/freepops-expat/expat/.libs/" This is not allowed because the path /tmp/freepops-expat/expat/.libs/ is never used. 0-4 On %install stage: - install -m755 (and extra) Use "install -p" to keep timestamps. 0-5 On %post %postun %preun stage: %post: /sbin/chkconfig --add freepopsd This means that spec file should have the entry: Requires(post): /sbin/chkconfig (and same for other). Please check: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets 0-6 On %files stage: - /etc/rc.d/init.d/freepopsd - %{_sysconfdir}/sysconfig/freepopsd Please use %{_sysconfdir} BOTH. - %{_datadir}/%{name} %{_datadir}/%{name}/lua %{_sysconfdir}/freepops/ All the directories aboveare not owned by any packages. 0-6 For debuginfo package: -------------------------------------------------- E: freepops-debuginfo script-without-shebang /usr/src/debug/freepops-0.0.99/modules/src/luacompat/compat-5.1r4/compat-5.1.h E: freepops-debuginfo wrong-script-end-of-line-encoding /usr/src/debug/freepops-0.0.99/modules/src/luacompat/compat-5.1r4/compat-5.1.h E: freepops-debuginfo script-without-shebang /usr/src/debug/freepops-0.0.99/modules/src/luacompat/compat-5.1r4/compat-5.1.c E: freepops-debuginfo wrong-script-end-of-line-encoding /usr/src/debug/freepops-0.0.99/modules/src/luacompat/compat-5.1r4/compat-5.1.c -------------------------------------------------- - For this case: * 'script-without-shebang' means that this file has incorrect permission. Change the permission to 0644. * 'wrong-script-end-of-line-encoding' means this file has Windows-like (CRLF) end-of-line encoding. Fix this by using dos2unix or use: sed -i -e 's|\r||' <file> . - Build log says: --------------------------------------------------- + /usr/lib/rpm/find-debuginfo.sh /home/tasaka1/rpmbuild/BUILD/freepops-0.0.99 extracting debug info from /var/tmp/freepops-0.0.99-1.tmp1-buildroot/usr/bin/freepopsd cpio: freepops-0.0.99/modules/src/getdate/getdate-curl-7.11.0/getdate.c: No such file or directory 1479 blocks --------------------------------------------------- This means that getdate.c should be installed into debuginfo rpm, however, it is missing. Then build log (with debugging with 'H=""') says: --------------------------------------------------- echo " linking libgetdate.a" linking libgetdate.a ar r libgetdate.a getdate.o 1>/dev/null 2>/dev/null cp libgetdate.a /home/tasaka1/rpmbuild/BUILD/freepops-0.0.99/modules/lib cp getdate.h /home/tasaka1/rpmbuild/BUILD/freepops-0.0.99/modules/include rm getdate.c <- here echo -n echo -n -------------------------------------------------- This is incorrect and should be fixed. Well, then 1. From http://fedoraproject.org/wiki/Packaging/Guidelines : * Use rpmlint - rpmlint is not silent (for srpm) E: freepops configure-without-libdir-spec This means that configure doesn't specify libdir. For this package this may be ignored, however, you can suppress this error by explicitly using '--libdir=%{_libdir}'. 2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines : = Seems okay but for the issues above. 3. Other things I have noticed : * %doc - I think 'TODO' should be added. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review