Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: andutteye-client - Andutteye Software Suite Monitoring agent https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211319 ------- Additional Comments From faucamp@xxxxxxxxxx 2006-11-15 10:51 EST ------- (In reply to comment #7) > Thanx for all input! Hopefully it will go smoother on future packets when i have > learned the Fedora standard correctly :-). We all learn this way... :-) You'll find that Fedora's package guidelines will assist you greatly in making quality packages for other distributions also, should the need ever arise. >Is this the right way to go if one > wants to change locations on the software when the packed software in the Source > tarbundle? have different locations defined? > > <snip> > %install > mkdir -p %{buildroot}%{andutteye_bin_dir} > install -m 0755 opt/andutteye/backbone/andutteye-api-linux.pl > %{buildroot}%{andutteye_bin_dir} > install -m 0755 opt/andutteye/bin/andutteyed > %{buildroot}%{andutteye_bin_dir} > install -m 0755 opt/andutteye/utils/* > %{buildroot}%{andutteye_bin_dir} > install -m 0644 opt/andutteye/LICENSE > rm -rf %{buildroot}/opt/andutteye > </snip> > You can do it this way, but *if* your source tarball has a makefile, try to rather create an "install target" patch for it; its cleaner, and allows you to add (submit) it to the upstream source. In your case, this is fine (since the upstream source does not have any such makefile). A few comments: * don't use %{andutteye_*_dir}; use one of the standard macros, like %{_bindir}; you can find documentation on these macros in /usr/share/doc/rpm-4.4.2; they are defined in code in /usr/lib/rpm/macros. In short: %_prefix /usr %_exec_prefix %{_prefix} %_bindir %{_exec_prefix}/bin %_sbindir %{_exec_prefix}/sbin %_libexecdir %{_exec_prefix}/libexec %_datadir %{_prefix}/share %_sysconfdir %{_prefix}/etc %_sharedstatedir %{_prefix}/com %_localstatedir %{_prefix}/var %_libdir %{_exec_prefix}/lib %_includedir %{_prefix}/include %_oldincludedir /usr/include %_infodir %{_prefix}/info %_mandir %{_prefix}/man * Use -p for "install" and "cp" commands, to preserve timestamps. See: http://fedoraproject.org/wiki/Packaging/Guidelines#head-0239576e441f9ef53d175c4aec8c12868dffb5ab * Insert a "rm -rf %{buildroot}" command as the first line of %install * The final line in %install, "rm -rf %{buildroot}/opt/andutteye", should not be necessary, since the directory isn't created * In your %files section: %doc %{andutteye_doc_dir}/LICENSE, etc - the %{andutteye_doc_dir} is not necessary, as %doc automatically places these files in the correct dir (/usr/share/doc/%{name}-%{version}-${release}) * Also in %files, rather use the standard dir macros This is looking much better! :-) From now on, please increment the release tag for each subsequent spec publishing (and check that the changelog version-release info matches that of the spec ;-) ) Also, for other people to participate in the review, it will be necessary to build SRPMs for each release as well, so everything can be tested. Good luck! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review