Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=624461 Emmanuel Seyman <emmanuel.seyman@xxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #2 from Emmanuel Seyman <emmanuel.seyman@xxxxxxxxxxxxxxxx> 2010-08-22 09:07:11 EDT --- - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines including the Perl specific items [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=2416996 [x] Rpmlint output: perl-Snowball-Norwegian.noarch: W: no-manual-page-for-binary stemmer-no perl-Snowball-Norwegian.src: W: no-cleaning-of-buildroot %install perl-Snowball-Norwegian.src: W: no-cleaning-of-buildroot %clean perl-Snowball-Norwegian.src: W: no-buildroot-tag perl-Snowball-Norwegian.src: W: no-%clean-section perl-Snowball-Norwegian.src: W: invalid-url Source0: http://www.cpan.org/authors/id/A/AS/ASKSH/Snowball-Norwegian-1.2.tar.gz <urlopen error timed out> perl-Snowball-Norwegian.spec: W: no-cleaning-of-buildroot %install perl-Snowball-Norwegian.spec: W: no-cleaning-of-buildroot %clean perl-Snowball-Norwegian.spec: W: no-buildroot-tag perl-Snowball-Norwegian.spec: W: no-%clean-section perl-Snowball-Norwegian.spec: W: invalid-url Source0: http://www.cpan.org/authors/id/A/AS/ASKSH/Snowball-Norwegian-1.2.tar.gz <urlopen error timed out> 2 packages and 1 specfiles checked; 0 errors, 11 warnings. No man page for a binary. Ugh. [x] Package is not relocatable. [x] Buildroot is correct No buildroot defined, default is used [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: GPL+ or Artistic Note that the header of lib/Lingua/Stem/Snowball/No.pm says GPLv2 only while the pod embedded in the file says "under the same terms as Perl itself". Given that the module's META.yml says "license: perl", I'm going with the latter but it would be nice to notify upstream so that it can clarify this. [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. 24197e600ea4d9b5bb5ca9c175f14676 Snowball-Norwegian-1.2.tar.gz [x] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [-] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: rawhide.x86_64 [x] Package should compile and build into binary rpms on all supported architectures. Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=2416996 [!] Package has a %clean section, which contains rm -fR $RPM_BUILD_ROOT. [?] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane. [x] %check is present and the tests pass All tests successful. Files=3, Tests=20631, 6 wallclock secs ( 2.69 usr 0.17 sys + 6.06 cusr 0.15 csys = 9.07 CPU) Result: PASS APRPOVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review