Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=625242 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomspur@xxxxxxxxxxxxxxxxx --- Comment #5 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2010-08-22 07:49:17 EDT --- Nice software... I'm no sponsor, so just some comments for now: - it would be much more readable, if you use the same indentation everywhere (but that's just costmetic) - Buildroot tag is wrong: https://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#BuildRoot_tag But if you don't want to make this a package in el5, you could also delete it completely. - Please preserve timestamps, when copying files around (cp -a or install -p). - First line: prefer global vs define, See: https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define You could use this macro: https://fedoraproject.org/wiki/Packaging:Python#Macros - Please be a bit more explicit in %files: When using: %{python_sitelib}/ClusterShell/ %{python_sitelib}/ClusterShell-*-py?.?.egg-info you know, when building the egg failed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review