Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517849 --- Comment #8 from Rafael Aquini <aquini@xxxxxxxxx> 2010-08-21 10:47:53 EDT --- Jussi, Please consider the following review: Good: * Spec file naming follows package naming * Spec is legible and American English * No locale files * No shared libraries * No bundled libraries * Not relocatable * Default permissions are set * Macros used consistently * Package is code * No large documentation * No header files * No static libraries * Not a GUI application * Does not own files or directories from other packages * All filenames are utf8 NEEDSWORK [1] rpmlint complaints: mpiwrappers.src: W: no-url-tag mpiwrappers.src:83: W: macro-in-comment %{buildroot} mpiwrappers.src: W: no-cleaning-of-buildroot %clean mpiwrappers.src:30: W: mixed-use-of-spaces-and-tabs (spaces: line 30, tab: line 9) mpiwrappers.x86_64: W: no-url-tag mpiwrappers.x86_64: E: no-binary mpiwrappers.x86_64: W: no-documentation mpiwrappers-lam.x86_64: E: devel-dependency lam-devel mpiwrappers-lam.x86_64: W: no-url-tag mpiwrappers-lam.x86_64: W: no-documentation mpiwrappers-lam.x86_64: W: non-conffile-in-etc /etc/modulefiles/lam-x86_64 mpiwrappers-lam.x86_64: W: non-conffile-in-etc /etc/rpm/macros.lam-x86_64 mpiwrappers-openmpi.x86_64: E: devel-dependency openmpi-devel mpiwrappers-openmpi.x86_64: W: no-url-tag mpiwrappers-openmpi.x86_64: W: no-documentation mpiwrappers-openmpi.x86_64: W: non-conffile-in-etc /etc/rpm/macros.openmpi-x86_64 mpiwrappers-openmpi.x86_64: W: non-conffile-in-etc /etc/modulefiles/openmpi-x86_64 4 packages and 0 specfiles checked; 3 errors, 14 warnings. [2] Package name must follow Naming Guidelines, which states the name should match the upstream tarball / project name; [3] Source within SRPM must match the upstream source; Best regards -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review