Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=624833 Terje Røsten <terjeros@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |terjeros@xxxxxxxxxxxx --- Comment #6 from Terje Røsten <terjeros@xxxxxxxxxxxx> 2010-08-18 03:55:25 EDT --- Only some cosmetic comments: o have you sent patches upstream or are they from upstream, please add a comment in the spec about the patches? o for better readability add a empty line before the %clean section? o %config(noreplace) %_sysconfdir/dhcp_probe.cf: add {} in sysconfdir macro o %{_mandir}/man8/* -> %{_mandir}/man8/dhcp_probe.8* %{_mandir}/man5/* -> %{_mandir}/man5/dhcp_probe.cf.5* -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review