Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=624833 --- Comment #4 from Guillermo Gómez <guillermo.gomez@xxxxxxxxx> 2010-08-18 00:36:29 EDT --- 1. Please improve absolute path use in scriptlets for consistency (better use absolute paths) %post chkconfig --add dhcp_probe << rel path %preun if [ $1 = 0 ] ; then /sbin/chkconfig --del dhcp_probe << abs path fi 2. Requires are needed for chkconfig and service commands, http://fedoraproject.org/wiki/Packaging:SysVInitScript#Initscripts_in_spec_file_scriptlets 3. chkconfig dhcp_probe off would force a configuration change on upgrade, avoid it 4. SysV implement condrestart (and try-restart): restart the service if the service is already running, if not, do nothing 5. SysV implement force-reload: reload the configuration of the service and restart it so that it takes effect 6. Exit Codes for non-Status Actions and Exit Codes for the Status Action needs improovements following Initscripts must be on their best behavior :) dhcp_probe works fine and builds on koji, just need some love on the initscript -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review