Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622270 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #7 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-08-16 15:47:31 EDT --- Some notes: * License tag - From elementary-monochrome/AUTHORS: --------------------------------------------------- 8 This package is licensed under GNU General Public License version 2. --------------------------------------------------- From elementary/AUTHORS: --------------------------------------------------- 8 This package is licensed under GNU General Public License version 2. --------------------------------------------------- Therefore the license tag should be "GPLv2". * Timestamps - Please use "cp -a" instead of "cp -R" to keep timestamps on installed files as much as possible: https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps * Documentation - I think --------------------------------------------------- elementary-monochrome/AUTHORS elementary-monochrome/COPYING elementary/AUTHORS elementary/CONTRIBUTORS elementary/COPYING --------------------------------------------------- should also be installed as %doc and be installed under %_defaultdocdir. The example would be --------------------------------------------------- At %prep: mkdir -p doc/elementary{,-monochrome} cp -p elementary-monochrome/[A-Z]* doc/elementary-monochrome/ cp -p elementary/[A-Z]* doc/elementary/ And at %files: %doc doc/* --------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review