Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=624490 --- Comment #1 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-08-16 15:11:01 EDT --- Some notes: * License - The license tag for this package should be "MIT". ? cat command - What is the purpose of the following line? ------------------------------------------------------------------ cat %{buildroot}/%{geminstdir}/matchy.gemspec ------------------------------------------------------------------ * Documents - I think %geminstdir/countloc.rb can also be moved to %doc. * %defattr - Please set %defattr on -doc subpackage. ? %doc in -doc - Usually I think that setting %doc attribute on the files in -doc subpackage is redundant because the name of the rpm already says that that rpm is for documentation. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review