[Bug 624434] Review Request: UFW - Uncomplicated Firewall

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=624434

Jochen Schmitt <jochen@xxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jochen@xxxxxxxxxxxxxxx

--- Comment #1 from Jochen Schmitt <jochen@xxxxxxxxxxxxxxx> 2010-08-16 14:55:27 EDT ---
Hallo,

at first, it's nice, that your are trying to become a Fedora contributor.
Unfortunately, the rpmlint output you have posted contains several issues which
block a review of your package.

1.) On a noarch package you should use %{_prefix}/lib instead of %{_libdir}

2.) You should investigate work to fix your file permissions on your package.
You can use the rpmls command from the rpmdevtools package to view the
filepermission of the packaged files without installing your package.

3.) you should read

https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files

because you seems to have an issue of handling of the locales of your package.

4.) you should inverstigate some work into your init scripts. Unfortunately
there is a plan to convert to systemd on F-14. Because, I not a specialist
about systemd, you may ask on devel@xxxxxxxxxxxxxxxxxxxxxxx for further
assistance.

Best Regards:

Jochen Schmitt

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]