Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=623871 Ding-Yi Chen <dchen@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |dchen@xxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |dchen@xxxxxxxxxx --- Comment #1 from Ding-Yi Chen <dchen@xxxxxxxxxx> 2010-08-15 22:15:43 EDT --- Hi, Just done a quick review, and found some problem. 1. It does not build with: koji build --scratch dist-f13 SRPMS/flies-python-client-0.0.2-1.fc13.src.rpm Seems like you need to remove BuildArch: noarch from your spec. 2. Error messages from using following command: find . -name "flies-python-client*.rpm" -exec rpmlint -i '{}' \; flies-python-client.src: E: description-line-too-long C Flies Python client is a client that communicate with Flies server for creating project Your description lines must not exceed 80 characters. If a line is exceeding this number, cut it to fit in two lines. flies-python-client.src: E: no-changelogname-tag There is no %changelog tag in your spec file. To insert it, just insert a '%changelog' in your spec file and rebuild it. flies-python-client.src: W: no-url-tag The URL tag is missing. flies-python-client.src:37: W: libdir-macro-in-noarch-package (main package) %{_libdir}/* The %{_libdir} or %{_lib} macro was found in a noarch package in a section that gets included in binary packages. This is most likely an error because these macros are expanded on the build host and their values vary between architectures, probably resulting in a package that does not work properly on all architectures at runtime. Investigate whether the package is really architecture independent or if some other dir/macro should be instead. flies-python-client.src: W: no-cleaning-of-buildroot %install You should clean $RPM_BUILD_ROOT in the %clean section and in the beginning of the %install section. Use "rm -rf $RPM_BUILD_ROOT". Some rpm configurations do this automatically; if your package is only going to be built in such configurations, you can ignore this warning for the section(s) where your rpm takes care of it. 1 packages and 0 specfiles checked; 2 errors, 3 warnings. flies-python-client.noarch: E: explicit-lib-dependency python-polib You must let rpm find the library dependencies by itself. Do not put unneeded explicit Requires: tags. flies-python-client.noarch: E: description-line-too-long C Flies Python client is a client that communicate with Flies server for creating project Your description lines must not exceed 80 characters. If a line is exceeding this number, cut it to fit in two lines. flies-python-client.noarch: E: no-changelogname-tag There is no %changelog tag in your spec file. To insert it, just insert a '%changelog' in your spec file and rebuild it. flies-python-client.noarch: W: no-url-tag The URL tag is missing. flies-python-client.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/fliesclient/flies.py 0644L /usr/bin/env This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. flies-python-client.noarch: E: zero-length /usr/share/doc/flies-python-client-0.0.2/README -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review