Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=623425 --- Comment #11 from Chen Lei <supercyper1@xxxxxxxxx> 2010-08-15 21:48:31 EDT --- (In reply to comment #10) > Thanks for the review, Orcan! > > > * The Group tag for the main package should be System Environment/Libraries > > I disagree here. Both PyQt4 and pygtk2 use the group Development/Languages. > Actually, python modules should use Development/Libraries, Development/Languages is for python/perl runtime or compiler(e.g. gcc) > > * I am also not sure about the naming of the package. The guideline says: > > """There is an exception to this rule. If the upstream source has "py" (or > > "Py") in its name, you can use that name for the package. So, for example, > > pygtk is acceptable. """ > > PySide should get Python 3 compatibility very soon now, so we'll most likely > end up with separate packages for both Python 2 and Python 3. Fedora Python > guidelines require that Python 3 modules need to be prefixed with python3-. I > think it looks nicer if the packages are called "python-pyside" and > "python3-pyside" as opposed to just plain "pyside" and "python3-pyside". > > > > Note that it says "you can" and not "you should/must". Shall we name the > > package just PySide? You can add a virtual provides "python-pyside" if you want > > Debian compatibility. Note also that Debian calls PyQt4 as python-qt4, very > > strange. There are other naming weirdnesses on Debian too. I think that it is > > Debian who deviates from upstreams. > > In this case, it's _upstream_ that's mostly using the name "python-pyside" in > their packaging page: http://www.pyside.org/downloads/ > Variations found in this page are: > python-pyside > pyside-qt4 > pyside-git > python-PySide will be the preferred name for this package since python3 will be supported soon, it'll better to always add python- to upstream name. See https://bugzilla.redhat.com/show_bug.cgi?id=603245#c15 . Following debian naming convention is a bit violation of FPG. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review