Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622313 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on|624290 | AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-08-15 14:27:53 EDT --- Initial comments * BR / tests - It seems that "BR: rubygem(shoulda)" is only needed when enabling tests. (Currently your srpm builds without "BR: rubygem(shoulda)". - And, instead would you consider to package rubygem-jnunemaker-matchy to enable tests? It seems that with installing this gem (and modifying Rakefile a bit) all tests seem to succeed. * Creating -doc - As I said in ruby-sig mailing list, (for this gem) I suggest to create -doc subpackage. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review