[Bug 527549] Review Request: osm2go - A simple openstreetmap editor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=527549

--- Comment #22 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-08-15 11:34:55 EDT ---
Sorry, Fabian, I've still some things to nag about. :) But as far as I see,
that's all, and the package should be ready afterwards.

Remove file COPYING from %{_datadir}/%{name}/


The following typos reported by rpmlint should be fixed:
  friendlyness -> friendliness
  maximim -> maximum


I suggest to replace 
  %{_mandir}/man*/%{name}*.*
with the more specific variant
  %{_mandir}/man1/%{name}.1*
since there's only one manpage to add.


The source tarball is available on the maemo website again:
http://repository.maemo.org/extras/pool/fremantle/free/source/o/osm2go/
I recommend to use this original location in Source0 instead of the mirror.
Also remove the preceding comment so that the rpmlint warning goes away:
osm2go.src:12: W: macro-in-comment %{version}

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]