Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622293 --- Comment #4 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2010-08-15 07:08:18 EDT --- Few more notes: * Please, add the following line to the head of your spec to suppress bogus debuginfo generation %global debug_package %{nil} * Please, add "%check" section with "make test" in it You may find it useful to take a look at the following spec-file for the real-world examples: http://pkgs.fedoraproject.org/gitweb/?p=erlang-mochiweb.git;a=blob;f=erlang-mochiweb.spec;hb=HEAD * Consider adding virtual "Provides: ErlyDTL = %{version}-%{release}" (for those who will (accidentally) install it with "yum install ErlyDTL". This is NOT a blocker - feel free to add or reject this proposal. In fact its just a matter of taste, however if you decide to add this (or some else) Provides it won't be easy to remove them in the future. * You don't using parallel make - either enable it with "make %{?_smp_mflags}" or add comment if the package cannot be built with parallel make. *Some files in /examples/ directory have executable permissions. You need to drop these privileges at %prep section. Just add a line there with something like this: find examples/ -type f -executable -exec chmod -x {} \; -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review