Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=623425 Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |oget.fedora@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |oget.fedora@xxxxxxxxx Flag| |fedora-review? --- Comment #9 from Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> 2010-08-14 14:36:36 EDT --- Okay, here is the full review: * koji scratch build failed http://koji.fedoraproject.org/koji/taskinfo?taskID=2401747 ! rpmlint says python-pyside-devel.x86_64: W: no-documentation It seems like the directory doc/ contains some developer documentation. No? Also the file ChangeLog contains developer oriented information. * The file PySide/licensecomment.txt should be packaged. * The source files in libpyside/ are "LGPLv2 with exceptions", however the source files in PySide/ does not specifiy a license in their headers. Please notify upstream. However the file PySide/licensecomment.txt gives us a hint that these files are LGPLv2. So the full license tag should be License: LGPLv2 and LGPLv2 with exceptions Please verify this with upstream and note this in the specfile. * Patch0: python-pyside-release-type.patch Is this a Fedora specific patch? Is it upstreamable? * The Group tag for the main package should be System Environment/Libraries ! The file tests/util/valgrind-python.supp contains hardcoded /usr/lib/ strings. I don't know if this affects the tests. * I am also not sure about the naming of the package. The guideline says: """There is an exception to this rule. If the upstream source has "py" (or "Py") in its name, you can use that name for the package. So, for example, pygtk is acceptable. """ Note that it says "you can" and not "you should/must". Shall we name the package just PySide? You can add a virtual provides "python-pyside" if you want Debian compatibility. Note also that Debian calls PyQt4 as python-qt4, very strange. There are other naming weirdnesses on Debian too. I think that it is Debian who deviates from upstreams. ! QtMultimedia_audio_test fails. This may be a python-2.7 incompatibility. 185: Traceback (most recent call last): 185: File "/builddir/build/BUILD/pyside-qt4.6+0.4.0/tests/QtMultimedia/audio_test.py", line 30, in testListDevices 185: self.assert_(False) 185: AssertionError: False is not True ! The Phonon test segfaults DEBUG: 186: .../builddir/build/BUILD/pyside-qt4.6+0.4.0/tests/run_test.sh: line 13: 29595 Segmentation fault (core dumped) $3 $4 DEBUG: 186/189 Test #186: phonon_basic_playing_test .......................***Failed 2.59 sec I hope this is not significant. ! You don't require pkgconfig. This is fine if this package is Fedora only. ? On the devel package, do we really need Requires: shiboken-devel I checked the other Requires, and I verified they are all needed, but I can't find the use of this one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review