Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=624179 d. johnson <drjohnson1@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |drjohnson1@xxxxxxxxx --- Comment #3 from d. johnson <drjohnson1@xxxxxxxxx> 2010-08-13 20:47:32 EDT --- Not an official reviewer. % rpmlint zathura-* zathura-debuginfo.i686: E: empty-debuginfo-package 2 packages and 0 specfiles checked; 1 errors, 0 warnings. - Package meets naming and packaging guidelines - Spec file matches base package name. - Spec has consistent macro usage. - Meets Packaging Guidelines. - License - BSD-like, but does not match http://en.wikipedia.org/wiki/BSD_licenses - License field in spec matches (BSD) - License file included in package - Spec in American English - Spec is legible. - Sources match upstream md5sum: - BuildRequires correct - Package has %defattr and permissions on files is good. - Package has a correct %clean section. - Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) - Package is code or permissible content. - Packages %doc files don't affect runtime. - Headers/static libs in -devel subpackage. - .la files are removed. - Package compiles and builds on at least one arch. - Package has no duplicate files in %files. - Package doesn't own any directories other packages own. - Package owns all the directories it creates. - No rpmlint output. (see above) - final provides and requires are sane: (include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =; rpm -qp --requires $i; echo; done manually indented after checking each line. I also remove the rpmlib junk and anything provided by glibc.) libatk-1.0.so.0 libcairo.so.2 libfontconfig.so.1 libfreetype.so.6 libgdk-x11-2.0.so.0 libgdk_pixbuf-2.0.so.0 libgio-2.0.so.0 libglib-2.0.so.0 libgmodule-2.0.so.0 libgobject-2.0.so.0 libgthread-2.0.so.0 libgtk-x11-2.0.so.0 libm.so.6 libm.so.6(GLIBC_2.0) libpango-1.0.so.0 libpangocairo-1.0.so.0 libpangoft2-1.0.so.0 libpoppler-glib.so.4 SHOULD Items: - Should build in mock. (Does) - Should build on all supported archs (Does) - Should function as described. - Should have sane scriptlets. (None) - Should have subpackages require base package with fully versioned depend. (None) - Should have dist tag (Does) - Should package latest version - check for outstanding bugs on package. (For core merge reviews) Issues: 1. License needs verification from author. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review