Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=603245 --- Comment #11 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2010-08-13 18:52:46 EDT --- (In reply to comment #10) > IMHO, the name python-zmq don't match Fedora naming guideline, though I think > the naming guideline for python modules isn't clearly enough and cause many > inconsistencies in the repo. See: http://fedoraproject.org/wiki/PackageNamingGuidelines#Addon_Packages_.28python_modules.29 """ [snip] This makes a package name format of python-$NAME. When in doubt, use the name of the module that you type to import it in a script. """ The imported module is zmq -> python-zmq If it would be pyzmq -> python-pyzmq, but it isn't. Or what do you mean? > Currently, many existed py* packages(e.g. pygtk2) are already named as > python3-py*. Maybe we should adopt python modules naming guldeine from debian, > which seems more clear than ours. Don't know the guidelines from debian... Maybe you could bring that up to the guidelines commitee? http://lists.fedoraproject.org/pipermail/packaging/ Parag: Thanks for the review. Any doubts to the name "python-zmq"? (In reply to comment #9) > python-zmq.src:139: W: macro-in-comment %{buildroot} > python-zmq.src:139: W: macro-in-comment %{python3_sitearch} > ==> If comments are only for temporary then its ok to keep them otherwise > remove those lines from spec. This shall remember me for enabling the testsuite as soon as python3-nose is available. So this is partly temarary (don't know when nose will support python3). > - You used everywhere %{buildroot} except one place used $RPM_OPT_FLAGS" > Please fix this Done locally. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review