[Bug 601115] Review Request: lockfile-progs - safely lock and unlock files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=601115

Michael Schwendt <mschwendt@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mschwendt@xxxxxxxxx

--- Comment #7 from Michael Schwendt <mschwendt@xxxxxxxxx> 2010-08-13 17:28:54 EDT ---
The "make check" target looks suitable for a %check section.


> I suggest to replace %{__mkdir} and %{__cp} with plain mkdir and cp,
> respectively

*Highly* recommended, especially since the "Makefile" doesn't use those RPM
macros either.  (btw, %{__mkdir_p} would also exist :-p)


> CFLAGS='%{optflags}'

Strictly necessary as else it won't use Fedora's global flags.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]