Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=595011 --- Comment #10 from Rafael Aquini <aquini@xxxxxxxxx> 2010-08-13 13:16:52 EDT --- David, Please, consider the following review: Good: * Package is named sshdfilter which follows the upstream project name * spec file naming follows package naming * License in spec and license text is GPL which is open source * License text included in the tarball and listed on %file. * Spec is legible and American English * No locale files * No shared libraries * No bundled libraries * Not relocatable * No directories created unowned * No duplicate files * Default permissions are set * Package is code * No large documentation * No %doc files are used at runtime * No header files * Not a GUI application * Does not own files or directories from other packages * All filenames are utf8 NEEDSWORK: [1] ask upstream to include a license disclaimer as a header of sshdfilter perl script [2] chkconfig line is missing in sshdfilter SysVInitScript. See http://fedoraproject.org/wiki/Packaging:SysVInitScript#.23_chkconfig:_line [3] Source **DOES NOT** matches upstream: * http://www.csc.liv.ac.uk/~greg/sshdfilter-1.5.7.tar.gz a022aeeb80b4a71e86d330d89dafb89d Downloads/sshdfilter-1.5.7.tar.gz dda362b80c0a3f8297b08ff6f831fcbc rpmbuild/SOURCES/sshdfilter-1.5.7.tar.gz NOTE: [3] is a real Blocker to this package. You can't ship source that mismatch upstream's within your SRPM. That is forbidden accordingly to Packaging Guidelines and Review Policies. As I've wrote on Comment #2, if you are packaging a software without upstream maintenance, you should consider to take over the maintenance and become yourself this software upstream. Regards -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review