Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=623868 Paul Flo Williams <paul@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul@xxxxxxxxxxxxx --- Comment #2 from Paul Flo Williams <paul@xxxxxxxxxxxxx> 2010-08-13 11:18:49 EDT --- I am not yet a packager, so this is just an unofficial pre-review, and my first one of those. + OK ? ISSUE - N/A + Package meets naming and packaging guidelines [follows latest font template] + Spec file matches base package name. + Spec has consistant macro usage. + Meets Packaging Guidelines. + License ? License field in spec matches + License file included in package + Spec in American English + Spec is legible. + Sources match upstream md5sum: c97c000a4084bed7108f4c75eae657c0 Cantarell-2009-07-17.zip - Package needs ExcludeArch + BuildRequires correct - Spec handles locales/find_lang - Package is relocatable and has a reason to be. - Package has %defattr and permissions on files is good. + Package has a correct %clean section. - Package has correct buildroot [no longer specified] + Package is code or permissible content. - Doc subpackage needed/used. + Packages %doc files don't affect runtime. - Headers/static libs in -devel subpackage. - Spec has needed ldconfig in post and postun - .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. - -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. - Package is a GUI app and has a .desktop file + Package compiles and builds on at least one arch. + Package has no duplicate files in %files. + Package doesn't own any directories other packages own. + Package owns all the directories it creates. + No rpmlint output. [paul@palant SPECS]$ rpmlint abattis-cantarell-fonts.spec \ ../RPMS/noarch/abattis-cantarell-fonts-1.001-1.fc13.noarch.rpm \ ../SRPMS/abattis-cantarell-fonts-1.001-1.fc13.src.rpm abattis-cantarell-fonts.spec:4: W: macro-in-comment %{name} abattis-cantarell-fonts.spec:4: W: macro-in-comment %{version} abattis-cantarell-fonts.spec: W: no-buildroot-tag abattis-cantarell-fonts.src:4: W: macro-in-comment %{name} abattis-cantarell-fonts.src:4: W: macro-in-comment %{version} abattis-cantarell-fonts.src: W: no-buildroot-tag 2 packages and 1 specfiles checked; 0 errors, 6 warnings. macro-in-comment is ignorable no-buildroot-tag is obsolete + final provides and requires are sane: Provides: abattis-cantarell-fonts-1.001-1.fc13.noarch.rpm config(abattis-cantarell-fonts) = 1.001-1.fc13 font(:lang=aa) font(:lang=af) font(:lang=an) font(:lang=ast) font(:lang=ay) font(:lang=bi) font(:lang=br) font(:lang=bs) font(:lang=ca) font(:lang=ch) font(:lang=co) font(:lang=crh) font(:lang=cs) font(:lang=csb) font(:lang=cy) font(:lang=da) font(:lang=de) font(:lang=en) font(:lang=eo) font(:lang=es) font(:lang=et) font(:lang=eu) font(:lang=fi) font(:lang=fil) font(:lang=fj) font(:lang=fo) font(:lang=fr) font(:lang=fur) font(:lang=fy) font(:lang=ga) font(:lang=gd) font(:lang=gl) font(:lang=gv) font(:lang=ho) font(:lang=hr) font(:lang=hsb) font(:lang=ht) font(:lang=hu) font(:lang=ia) font(:lang=id) font(:lang=ie) font(:lang=io) font(:lang=is) font(:lang=it) font(:lang=jv) font(:lang=ki) font(:lang=kj) font(:lang=kl) font(:lang=ku-tr) font(:lang=kwm) font(:lang=la) font(:lang=lb) font(:lang=lg) font(:lang=li) font(:lang=lt) font(:lang=lv) font(:lang=mg) font(:lang=mh) font(:lang=ms) font(:lang=mt) font(:lang=na) font(:lang=nb) font(:lang=nds) font(:lang=ng) font(:lang=nl) font(:lang=nn) font(:lang=no) font(:lang=nr) font(:lang=nso) font(:lang=ny) font(:lang=oc) font(:lang=om) font(:lang=pap-an) font(:lang=pap-aw) font(:lang=pl) font(:lang=pt) font(:lang=rm) font(:lang=rn) font(:lang=rw) font(:lang=sc) font(:lang=se) font(:lang=sg) font(:lang=sk) font(:lang=sl) font(:lang=sma) font(:lang=smj) font(:lang=smn) font(:lang=sn) font(:lang=so) font(:lang=sq) font(:lang=ss) font(:lang=st) font(:lang=su) font(:lang=sv) font(:lang=sw) font(:lang=tk) font(:lang=tl) font(:lang=tn) font(:lang=tr) font(:lang=ts) font(:lang=uz) font(:lang=vo) font(:lang=vot) font(:lang=wa) font(:lang=wen) font(:lang=wo) font(:lang=xh) font(:lang=yap) font(:lang=za) font(:lang=zu) font(cantarell) abattis-cantarell-fonts = 1.001-1.fc13 Requires: config(abattis-cantarell-fonts) = 1.001-1.fc13 fontpackages-filesystem SHOULD Items: + Should build in mock. + Should build on all supported archs + Should function as described. + Should have sane scriptlets. - Should have subpackages require base package with fully versioned depend. + Should have dist tag + Should package latest version - check for outstanding bugs on package. (For core merge reviews) Fonts MUST Items: (from Packaging:FontsPolicy) + Fonts released upstream in separate archives must be in separate src.rpm + Each font family must be in a separate (sub)package + Different faces of font family must be in a single (sub)package Fonts SHOULD Items: ? Fonts should be built from source whenever upstream provides them in source format Issues: 1. License should be "GPLv3+ with exceptions". 2. FontForge sources are provided, so they should be used to build the TTFs. You should ask upstream to provide a makefile to help automate this. I'll note that it is good to see that upstream has paid attention to the font metadata: it is not unusual to see fonts released under open licenses in which the metadata appears to place restrictions on usage (fsType field). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review