Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622002 --- Comment #2 from Arun SAG <sagarun@xxxxxxxxx> 2010-08-13 03:27:53 EDT --- (In reply to comment #1) > #001: In "Summary:", for nouns, please use "Ruby on Rails" and "Emacs". > Ok. > #002: For your comments, please give a newline above and below, and give a > white-space after '#' as in: > > # The source of this package was pulled from upstream's vcs. > # use the following command to generate the tar ball: > > The .spec file must be readable. Ok. > > #003: As per the GNU Emacs template please use: > > %global pkg foo > %global pkgname Foo Sure. > > #004: Source0 should point to a URL that is available for download. Please > upload the same sources that you used for packaging at your fedorapeople.org > website, and mention the URL. > Ok. > #005: Use the following: > > %{__rm} > %{__install} > This practice is discouraged, please read http://lists.fedoraproject.org/pipermail/devel/2010-March/133466.html > #006: In emacs-rinari-init.el, please don't include ido-mode, since, it is only > recommended and not required. We don't need to force it on the end user. Just > use: > > ;; Init file for rinari plugin > (add-to-list 'load-path "/usr/share/emacs/site-lisp/rinari/") > (require 'rinari) > I will remove the ido-mode. > I have tested the package, and it works. Thank you shakthi for the comments, i will fix the spec and update the srpm tonight. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review