Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=621416 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #2 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-08-10 15:40:23 EDT --- Here are some more comments: - the license of the EPSG data files contains the following restriction: "The data may not be distributed for profit by any third party" I think this clause might be a problem. FE-Legal should have a look. - drop BR: gzip and the call of gzip in %install as manpages are compressed automatically - "%setup -q" should be sufficient in %prep - I suggest to keep the timestamps of the csv files, e.g. by changing the for loop like this: for f in `find csv -type f | grep -q ISO-8859` ; do chmod 644 $f iconv -f ISO-8859-1 -t UTF-8 $f > ${f}.tmp touch -r $f $f.tmp mv -f $f.tmp $f done - don't mix $RPM_BUILD_ROOT and %{buildroot}, use only one of them - Delete the libtool archives (.la) and the static library (.a) in %install and remove both from %file (add "--disable-static" to %configure"). If the static lib is required by some reason, it should go to a -static package. - I would remove, or at least prefix the generated manpages because some of the filenames, like index.1, are too generic and could conflict. Also, the man section should be 3 instead of 1. To me, it would be sufficient to provide the html docs. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review