Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=611454 --- Comment #8 from David Riches <david.r@xxxxxxxxxxxxxx> 2010-08-10 07:25:12 EDT --- Thanks for the comments, I'm not sure on the %name issue though, as if I remove the tag, and manually add it to setup, then rpmlint fails :-/ so I have kept that for now, and see if there are any more comments/suggestions. Regarding the rest, I have renamed the package, removed the CFLAGS, updated the changelog, buildrequires and included the latest source. Thanks again for all the feedback, its much appreciated. SPEC: http://dcr226.fedorapeople.org/SPECS/py-bcrypt.spec SRPM: http://dcr226.fedorapeople.org/SRPMS/py-bcrypt-0.2-1.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review