[Bug 621898] Review Request: libwbxml - Library and tools to parse, encode and handle WBXML documents

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=621898

--- Comment #8 from Petr Pisar <ppisar@xxxxxxxxxx> 2010-08-10 04:57:29 EDT ---
New spec and SRPM uploaded:

Spec URL: http://ppisar.fedorapeople.org/libwbxml/libwbxml.spec
SRPM URL:
http://ppisar.fedorapeople.org/libwbxml/libwbxml-0.10.8-1.fc13.src.rpm

Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2390930

$ rpmlint libwbxml.spec ../SRPMS/libwbxml-0.10.8-1.fc13.src.rpm
../RPMS/x86_64/libwbxml-*
libwbxml-devel.x86_64: W: no-documentation
libwbxml.x86_64: W: obsolete-not-provided wbxml2
libwbxml.x86_64: W: no-manual-page-for-binary xml2wbxml
libwbxml.x86_64: W: no-manual-page-for-binary wbxml2xml
4 packages and 1 specfiles checked; 0 errors, 4 warnings.


Diff to old spec file:

--- libwbxml.spec 2010-08-09 09:59:53.000000000 +0200
+++ /home/petr/rpmbuild/SPECS/libwbxml.spec 2010-08-10 10:47:49.005302937 +0200
@@ -12,7 +12,6 @@
 BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

 BuildRequires:  cmake, expat-devel, perl
-Provides:       wbxml2 = %{version}-%{release}
 Obsoletes:      wbxml2 <= 0.9.3

 %description
@@ -43,24 +42,21 @@

 %build
 # Upstream does not support in-source-directory building
-SRCDIR="$PWD"
-%define builddir ../build
-rm -rf %{builddir}
-mkdir %{builddir}
-cd %{builddir}
-%cmake "$SRCDIR"
-make %{?_smp_mflags}
+mkdir -p %{_target_platform}
+pushd %{_target_platform}
+%cmake ..
+popd
+make -C %{_target_platform} %{?_smp_mflags}


 %install
 rm -rf $RPM_BUILD_ROOT
-cd %{builddir}
-make install DESTDIR=$RPM_BUILD_ROOT
+make -C %{_target_platform} install/fast DESTDIR=$RPM_BUILD_ROOT
 rm -r $RPM_BUILD_ROOT/usr/share/doc/%{name}


 %check
-cd %{builddir}
+cd %{_target_platform}
 ctest


@@ -77,17 +73,16 @@
 %defattr(-,root,root,-)
 %doc AUTHORS BUGS ChangeLog COPYING GNU-LGPL NEWS README References THANKS
TODO
 %{_bindir}/*
-%{_libdir}/libwbxml2.so.0*
+%{_libdir}/libwbxml2.so.*

 %files devel
 %defattr(-,root,root,-)
-%doc AUTHORS BUGS ChangeLog COPYING GNU-LGPL NEWS README References THANKS
TODO
 %{_includedir}/*
 %{_libdir}/libwbxml2.so
 %{_libdir}/pkgconfig/libwbxml2.pc


 %changelog
-* Fri Aug 06 2010 Petr Pisar <ppisar@xxxxxxxxxx> - 0.10.8-1
+* Tue Aug 10 2010 Petr Pisar <ppisar@xxxxxxxxxx> - 0.10.8-1
 - 0.10.8 import
 - based on and obsoletes wbxml2-0.9.2-16

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]