Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=519521 --- Comment #12 from Ismael Olea <ismael@xxxxxxxx> 2010-08-09 16:54:41 EDT --- (In reply to comment #8) > Source0: should be a URL, so that spectool -g will work if possible. Well, this is a sourceforge URI. Attending to http://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net the URI supposed to be http://downloads.sourceforge.net/projects/kompozer/kompozer-0.8b3-src.tar.bz2 but it don't works. Instead, the one SF generates is http://sourceforge.net/projects/kompozer/files/current/0.8b3/kompozer-0.8b3-src.tar.bz2/download which confuses rpmbuild (it believes the file is named «download». > I don't > suppose there's a URL for the manpage, but if there is then you should inclide > that as well. I added the URL to the git web frontend to it. > I'm not sure what the nvu-related Provides: and Obsoletes: is about; is nvu > available in any Fedora repository currently? No as far as I know. But you know: Kompozer is obsoleting it... > You have Requires(pre): desktop-file-utils, but no %pre scriptlet at all. > Similarly, you call update-desktop-database and ldconfig in %post and %postun, > but have no dependencies for them. Ok: I added the post and postun and removed the pre. I didn't added glibc (for ldconfig) as a Requires(post) since feel is extremelly redundant. Hope I'm right. > This provides a whole lot of libraries that are also provided by xulrunner. I > think this is a significant problem. Seamonkey manages to avoid this by > turning off the dependency generator and managing some of the dependency > generation itself. I can't really offer any suggestions on how to do it > properly, though I'd bet the firefox/xulrunner/seamonkey maintainers (all the > same people) would have some suggestions. I'll wait for it. I recognize Mozilla/Kompozer's makefile is a little hell to manage. > The correct set of Fedora compiler flags are not used, and the debuginfo > package seems to be broken. These are related. You will need to get the > propler set of compiler flags (from %{optflags}) passed to the compiler. > Seamonkey seems to do this properly. > > The biggest issue I see, however, is that this is basically yet another forked > mozilla. Distributing a forked copy of something that's updated with security > issues once a week isn't something we should go about lightly; I'd want to see > discussion with the firefox/xulrunner maintainers and probably FESCo as well > (the latter due to the requirements of the no-bundled-libraries policy). I see your point for these thing. Again: Kompozer makefiles are a beast that barely upstream can control. Maybe an experienced maintainer of Seamonkey or similars would better guide us. I would be more than glad for enhancing the compiling scripts. The same applies with the duplicated code from Mozilla: upstream didn't be able to optimize it, or maybe they couldn't get the time for it. And I currently don't have neither time or skills for it. Obviously the best thing I can say about Kompozer in it's current presentation is it's the best and only app available in its class AFAIK :-) Suggestions are welcome! Current release (uploading to server): http://olea.org/paquetes-rpm/fedora-13/kompozer-0.8-0.5.b3.fc13.src.rpm http://olea.org/tmp/kompozer.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review