Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=619437 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #11 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-08-09 06:07:03 EDT --- Helio, here are some more things to consider: - If you want to build the package for Fedora only (and not for EPEL), you can remove the BuildRoot tag (and also 'rm -rf %{buildroot}' in %install) [1]. Otherwise, it's recommended to use one of the tags listed at [2]. - you can drop BR: python (it's added automatically as a dependency) - add %dir %{_sysconfdir}/bash_completion.d/ to %files (the package should own this directory, see [3]) [1] http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag [2] http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#BuildRoot_tag [3] http://fedoraproject.org/wiki/Packaging/Guidelines#Multiple_packages_own_files_in_a_common_directory_but_none_of_them_needs_to_require_the_others. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review