Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=620177 --- Comment #9 from Adel Gadllah <adel.gadllah@xxxxxxxxx> 2010-08-08 07:38:24 EDT --- (In reply to comment #8) > I'd argue that using the date in release field gives the user a better sense > how fresh the snapshot is. The git hash is only useful if one can look it up in > the git repo; without the repo the hash isn't very informative. True but that is what the changelog is for; we don't add the date to "foo-2.0-1" either even thought it would tell the user when "2.0" has been released. > In any case, it's the official guidelines which suggest to include date in the > release field if you are packaging a snapshot. I think it makes sense to keep > naming consistent in the distro. Even if you think that including the date + > the word "git" in release field is redundant, I believe it is useful to keep > naming consistent with other packages. Anyway yeah you are right; changing this is beyond the scope of a package review, so I have added the date and "git" to the release. New srpm / spec: http://193.200.113.196/apache2-default/rpm/uprof.spec http://193.200.113.196/apache2-default/rpm/uprof-0.2-0.4.20100808gitb620fb7f9.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review