Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=600361 --- Comment #3 from Felix Kaechele <felix@xxxxxxxxxx> 2010-08-07 16:28:11 EDT --- Okay. Here we go with a few notes: - Why do you define name, version and release seperately? It's pretty redundant, since you can use exactly those macros you %define to get the values you define in the Name, Version, and Release tags - The BuildRoot tag is wrong. If you're not planning to build for EPEL, remove it. Otherwise refer to http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#BuildRoot_tag - What's the "Prefix" doing in there? Thats very Red Hat 7.3-ish ;) - How is the note in %build relevant to the build process? (i.e. what is it refering to?) - The Makfile of gobi_loader could use some tweaking: 1. You pass the $RPM_OPT_FLAGS to the make command, the Makefile however doesn't use them in any way. 2. You are using the %makeinstall macro. This is discouraged by Fedora. While you're at fixing the Makefile, refer to http://fedoraproject.org/wiki/Packaging/Guidelines#MakeInstall for more info on that. rpmlint doesn't show anything suspicious, so that is fine. For the future you might want to look at using rpmdev-newspec to create new specfiles from an up-to-date template and rpmdev-bumpspec for making the changelog entries. Those commands are provided by the rpmdevtools package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review