Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=621713 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-08-07 14:52:49 EDT --- Some notes. ? Version number - Would you write how we can identify the version number of this zip file? * License - In the zip file I see only GPLv3 "COPYING.txt" is included and no other information cannot be found in the zip which specifies the version of GPL this zip is licensed under. In this case we regard that this zip is licensed under "GPL+" (GPL at any version), see: https://fedoraproject.org/wiki/Licensing/FAQ#How_do_I_figure_out_what_version_of_the_GPL.2FLGPL_my_package_is_under.3F * BuildRoot - As I wrote in bug 620990, BuildRoot tag is no longer needed on Fedora (and EPEL6). * scriptlets - For updating GTK icon, please follow: https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache ("hicolor" must be replaced appropritely) ! Note - Not %postrun but %postun . * Misc notes: -------------------------------------------------------------- ln -sf ./distributor-logo-fedora.png distributor-logo.png -------------------------------------------------------------- - "./" is redundant and please remove this. * rpmlint issues -------------------------------------------------------------- faenza-icon-theme.noarch: E: script-without-shebang /usr/share/icons/Faenza-Dark/index.theme faenza-icon-theme.noarch: E: script-without-shebang /usr/share/icons/Faenza/index.theme -------------------------------------------------------------- - These errors are because these files have unneeded executable permission. Please change the permission of these files to 0644. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review