Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555018 --- Comment #19 from Taylon <taylon@xxxxxxxxxxxxx> 2010-08-07 08:44:03 EDT --- > The first two warnings can be ignored, however I prefer to add both the > BuildRoot tag as well as 'rm -rf $RPM_BUILD_ROOT' at the beginning of %install > for compatibility with older rpm version, but this is up to you. > The 3rd warning can be ignored as well, gconf files are no config files but > templates for the per-user files. > The error about the missing debuginfo needs to be fixed though (see below). Ok, I added both BuildRoot and 'rm -rf $RPM_BUILD_ROOT'. > Issues: > - Fix rpmlint as described above. For more info on the issue of the missing > sources in the debuginfo package see > http://fedoraproject.org/wiki/Packaging/Debuginfo > I haven't investigated it, but it is most likely due to the compiler flags not > being honored. I couldn't solve this issue. I checked a lot of things and everything seems to be ok. - I checked the build output to make sure that '-g' option was on CFLAGS and CXXFLAGS tags. - All binaries files are executable. - There's no setuid or setgid binaries. - I didn't find explicit strip symbols. I also took a look on the Makefile and configure.ac but I didn't find nothing wrong. What should I do? Ask for help on the Fedora Packaging list? > - Please use the new gconf macros from > http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf Done. > - Please change %{_mandir}/man1/gnac.1.gz to %{_mandir}/man1/gnac.1.* so the > extension .gz is not hardcoded. We might switch to bz2 or xz compressed > manpages some day. Done. > - Bug upstream about including a copy of GPLv2 instead of GPLv3 or change the > headers accordingly. Done. https://bugzilla.gnome.org/show_bug.cgi?id=625585 > - the timestamp of the source tarball in the srpm doesn't match the original > one, see https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps Done. > - I agree with Michael that the nonfree mimetypes in the desktop file and > profiles in /usr/share/gnac/profiles should be removed from the package. For > the desktop file you can use desktop-file-install instead of > desktop-file-validate and the xml files can be removed at the end of the > %install section. > I will then make a gnac-freeworld package at rpmfusion that provides a hidden > desktop file with the mimetypes, the profiles and requires the necessary > plugins. Sounds fair? Ok, so from desktop file I should remove: audio/vnd.rn-realaudio audio/x-wav audio/x-wma and from profiles: mp3 and wav related That's right? Thanks for the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review